Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): deprecate standalone mode #8478

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Nov 28, 2023

Checklist prior to review

This PR is partial implementation of #8449
It does not take into account transition from Zone CP to federated Zone CP (nothing changes here).

The default KUMA_MODE is now zone. You can still run as standalone however, it's immediately switched as zone with a warning.

Nothing really changes from a user perspective aside of that if they explicitly use KUMA_MODE=standalone, they will need to change it in future releases.

Multizone fails because of #8498

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…andalone-impl

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…andalone-impl

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

pkg/api-server/resource_endpoints.go Outdated Show resolved Hide resolved
pkg/config/app/kuma-cp/config.go Outdated Show resolved Hide resolved
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Nov 29, 2023
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review November 30, 2023 15:55
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner November 30, 2023 15:55
@jakubdyszkiewicz jakubdyszkiewicz requested review from lobkovilya and lukidzi and removed request for a team November 30, 2023 15:55
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still references to "standalone" mode in the codebase. You can find them by running:

grep -rI standalone .
./app/kumactl/cmd/install/install_control_plane_test.go:                Entry("--kds-global-address is used with standalone", errTestCase{
./app/kumactl/cmd/install/install_control_plane_test.go:                        extraArgs: []string{"--kds-global-address", "192.168.0.1:1234", "--mode", "standalone"},
./app/kuma-dp/pkg/dataplane/envoy/remote_bootstrap.go:                  log.Info("could not fetch bootstrap configuration, make sure you are not trying to connect to global-cp. retrying (this could help only if you're connecting to zone-cp or standalone).", "backoff", c
fg.ControlPlane.Retry.Backoff, "err", err.Error())
...

A more general note: instead of renaming current "zone" to "federated zone" (and "standalone" to just "zone") wouldn't it be easier for everyone to digest if we just named "standalone" a "standalone zone"? Just asking, I'm not very firm on this.

app/kuma-cp/cmd/run.go Outdated Show resolved Hide resolved
pkg/api-server/testdata/gui_other_files.html Show resolved Hide resolved
pkg/kds/zone/components.go Outdated Show resolved Hide resolved
pkg/plugins/runtime/k8s/plugin.go Outdated Show resolved Hide resolved
pkg/plugins/runtime/k8s/webhooks/validation_test.go Outdated Show resolved Hide resolved
test/e2e/helm/kuma_helm_upgrade.go Show resolved Hide resolved
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…andalone-impl

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please remember about the docs issue / PR.

@jakubdyszkiewicz jakubdyszkiewicz merged commit 0471cf3 into kumahq:master Dec 1, 2023
12 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/deprecate-standalone-impl branch December 1, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to start a zone without KDS and have it work like standalone
4 participants