New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kuma-cp): deprecate standalone mode #8478
feat(kuma-cp): deprecate standalone mode #8478
Conversation
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…andalone-impl Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…andalone-impl Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still references to "standalone" mode in the codebase. You can find them by running:
grep -rI standalone .
./app/kumactl/cmd/install/install_control_plane_test.go: Entry("--kds-global-address is used with standalone", errTestCase{
./app/kumactl/cmd/install/install_control_plane_test.go: extraArgs: []string{"--kds-global-address", "192.168.0.1:1234", "--mode", "standalone"},
./app/kuma-dp/pkg/dataplane/envoy/remote_bootstrap.go: log.Info("could not fetch bootstrap configuration, make sure you are not trying to connect to global-cp. retrying (this could help only if you're connecting to zone-cp or standalone).", "backoff", c
fg.ControlPlane.Retry.Backoff, "err", err.Error())
...
A more general note: instead of renaming current "zone" to "federated zone" (and "standalone" to just "zone") wouldn't it be easier for everyone to digest if we just named "standalone" a "standalone zone"? Just asking, I'm not very firm on this.
pkg/plugins/runtime/k8s/webhooks/gatewayapi_multizone_validator_test.go
Outdated
Show resolved
Hide resolved
…andalone-impl Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please remember about the docs issue / PR.
Checklist prior to review
This PR is partial implementation of #8449
It does not take into account transition from Zone CP to federated Zone CP (nothing changes here).
The default KUMA_MODE is now
zone
. You can still run asstandalone
however, it's immediately switched aszone
with a warning.Nothing really changes from a user perspective aside of that if they explicitly use KUMA_MODE=standalone, they will need to change it in future releases.
Multizone fails because of #8498
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --