Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): more explicit image tag in envoy.Dockerfile #8482

Merged
merged 1 commit into from Nov 29, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Nov 28, 2023

Dependabot will upgrade the image either way, we might as well see if the hash change moves us a minor version or not.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner November 28, 2023 14:22
@michaelbeaumont michaelbeaumont requested review from jakubdyszkiewicz and Automaat and removed request for a team November 28, 2023 14:22
@jakubdyszkiewicz
Copy link
Contributor

Hey, there is no description or linked issue. Could you describe why this change is useful/needed? Thanks

@bartsmykla bartsmykla merged commit ea36128 into kumahq:master Nov 29, 2023
17 checks passed
@michaelbeaumont michaelbeaumont deleted the chore/deps-envoy-docker branch November 29, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants