feat(kuma-cp) DNS resolver persistence #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 24, 2020 17:42
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
feat/dns_persistence
branch
from
9f2c5ee
to
a87061a
Compare
lobkovilya
reviewed
Jun 25, 2020
| resource := &config_model.ConfigResource{} | ||
| err := p.manager.Get(context.Background(), resource, store.GetByKey("kuma-internal-config", "")) | ||
| if err != nil { | ||
| err = p.manager.Create(context.Background(), resource, store.CreateByKey("kuma-internal-config", "")) |
There was a problem hiding this comment.
and isn't resource is empty at that line, why we try to create it?
nickolaev
commented
Jun 25, 2020
| resource := &config_model.ConfigResource{} | ||
| err := p.manager.Get(context.Background(), resource, store.GetByKey(dnsConfigKey, "")) | ||
| if err != nil { | ||
| if store.IsResourceNotFound(err) { |
| func (s *dnsResolver) SetVIPs(list VIPList) { | ||
| s.Lock() | ||
| defer s.Unlock() | ||
| s.viplist = list |
There was a problem hiding this comment.
I hope this does not get in the range of hundreds of thousands in practice.
pkg/dns/resolver.go
Outdated
| return service, nil | ||
| } | ||
|
|
||
| var _ DNSResolver = &dnsResolver{} |
There was a problem hiding this comment.
nit: Should this be on top?
pkg/dns/sync_test.go
Outdated
| close(stop) | ||
| }) | ||
|
|
||
| It("", func() { |
There was a problem hiding this comment.
Maybe a name here?
| } | ||
| } | ||
|
|
||
| if change { |
| } | ||
|
|
||
| func (d *vipsSynchronizer) synchronize() error { | ||
| vipList, err := d.persistence.Get() |
There was a problem hiding this comment.
But this will run also on the leader? We set the VIPs and then get them back?
nickolaev
commented
Jun 26, 2020
| @@ -64,6 +67,9 @@ func (d *vipsSynchronizer) Start(stop <-chan struct{}) error { | |||
| } | |||
|
|
|||
| func (d *vipsSynchronizer) synchronize() error { | |||
| if d.leadInfo.IsLeader() { | |||
lobkovilya
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a new ConfigStore inspired by the SecretsStore. Implement DNS persistence on top of it.
Example format of the resulting storage in ConfigMap on K8s: