feat(kuma-cp) sync policies over KDS #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/kuma-cp/cmd/run.go # pkg/config/app/kuma-cp/config.go # pkg/config/app/kuma-cp/kuma-cp.defaults.yaml
# Conflicts: # app/kuma-cp/cmd/run.go # pkg/config/kds/config.go # pkg/kds/reconcile/snapshot_generator.go # pkg/kds/server/components.go # pkg/kds/server/kds.go # pkg/kds/server/server.go # pkg/kds/server/server_test.go # pkg/kds/types.go # pkg/test/kds/verifier/context.go # pkg/test/kds/verifier/executables.go
# Conflicts: # go.sum
# Conflicts: # app/kumactl/pkg/install/k8s/control-plane/templates_vfsdata.go
# Conflicts: # app/kuma-cp/cmd/run.go # app/kumactl/pkg/install/k8s/control-plane/templates_vfsdata.go # pkg/config/kds/config.go # pkg/kds/reconcile/snapshot_generator.go # pkg/kds/server/components.go # pkg/kds/server/grpc.go # pkg/kds/server/kds.go # pkg/kds/server/server_test.go # pkg/kds/types.go # pkg/test/kds/verifier/context.go # pkg/test/kds/verifier/executables.go # test/e2e/kuma_deploy_global_remote_test.go
# Conflicts: # app/kuma-cp/cmd/run.go # app/kumactl/pkg/install/k8s/control-plane/templates_vfsdata.go # pkg/kds/global/components.go # pkg/kds/global/components_test.go # pkg/kds/reconcile/snapshot_generator.go # pkg/kds/remote/components.go # pkg/kds/server/components.go # pkg/kds/util/resource.go # pkg/test/kds/setup/server.go # test/e2e/kuma_deploy_global_remote_test.go
nickolaev
reviewed
Jun 26, 2020
nickolaev
reviewed
Jun 26, 2020
nickolaev
reviewed
Jun 26, 2020
| @@ -105,6 +105,7 @@ rules: | |||
| - get | |||
| - list | |||
| - watch | |||
| - create | |||
There was a problem hiding this comment.
Why only circuitbreaker got create? What about for example traffictraces or trafficlog?
| } | ||
|
|
||
| func ClusterTag(r model.Resource) string { | ||
| return r.GetSpec().(*mesh_proto.Dataplane).GetNetworking().GetInbound()[0].GetTags()[mesh_proto.ClusterTag] |
There was a problem hiding this comment.
Can we assume that there are inbounds? What if it's gateway?
| // That's why we can set 'Name' like this | ||
| m := util.ResourceKeyToMeta(newName, r.GetMeta().GetMesh()) | ||
| r.SetMeta(m) | ||
| func adjustIngressNetworking(cfg *clusters.ClusterConfig, rs model.ResourceList) { |
There was a problem hiding this comment.
We also need only one Ingress, when having 5 ingress instances we should only sync 1 to other clusters with LB IP
…into feat/kds-sync-policies
Add `kumactl install ingress --use-node-port` and default to using LoadBalancer in the Ingress service, when this flag is not set. Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Add `kumactl install control-plane --use-node-port` and default to using LoadBalancer in the Ingress service, when this flag is not set. Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Syncing policies over KDS
Issues resolved
Fix https://github.com/Kong/kuma/issues/804
Documentation