chore(*) add Universal entities in the e2e testing framework #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickolaev
changed the title
nickolaev
force-pushed
the
chore/e2e_universal
branch
from
dbdf538
to
da3cc42
Compare
added 2 commits
June 28, 2020 23:33
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
chore/e2e_universal
branch
from
da3cc42
to
840ccd1
Compare
added 5 commits
June 29, 2020 15:47
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
lobkovilya
reviewed
Jun 30, 2020
| var defaultDockerOptions = docker.RunOptions{ | ||
| Command: nil, | ||
| Detach: true, | ||
| //Entrypoint: "", |
There was a problem hiding this comment.
Is it also intentional?
lobkovilya
approved these changes
Jun 30, 2020
| } | ||
|
|
||
| func (s *UniversalApp) getIP() string { | ||
| cmd := SshCmd(s.sshPort, "getent", "hosts", s.container[:12]) |
| } | ||
|
|
||
| func (c *UniversalCluster) Exec(namespace, podName, containerName string, cmd ...string) (string, string, error) { | ||
| return "", "", nil |
There was a problem hiding this comment.
Could you please panic if a method is not implemented, otherwise we can unintentionally use some of them. And Exec probably could be deleted, maybe I shouldn't have introduced it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a Universal mode implementation for the E2E testing framework.
Issues resolved
Fix #773