Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(routes): handle routing if there are no TrafficRoutes #8614

Merged
merged 10 commits into from Dec 15, 2023
Merged

feat(routes): handle routing if there are no TrafficRoutes #8614

merged 10 commits into from Dec 15, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Dec 13, 2023 •
edited

Depends on #8602
See #8604

  • don't warn in outbound proxy generator

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont
test(MeshTCPRoute): improve and fix test cases
425be8a 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
feat(routes): only handle routing with new policies if no TrafficRout…
6a39f01 
…es exist

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner December 13, 2023 08:54
@michaelbeaumont michaelbeaumont requested review from jakubdyszkiewicz and Automaat and removed request for a team December 13, 2023 08:54
@michaelbeaumont
test(xds): add default-allow-all resource
cd0c33a 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(MeshTCPRoute): add new resources after change with MeshHTTP vs M…
9657a62 
…eshTCP

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore(TrafficRoute): only warn on missing TrafficRoute if there are s…
e00d314 
…ome TrafficRoute resources

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
feat: only route all with zone proxies without TrafficRoutes
a117efe 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont and others added 2 commits December 14, 2023 13:06
@michaelbeaumont
fix: don't error if no Dataplane
d65e6de 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@lukidzi @michaelbeaumont
fix: add mesh tag to dummy targetRefs
01be206 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(e2e): fix expectation in MeshHTTPRoute/MeshTCPRoute cases
5633ae8 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Dec 14, 2023
@michaelbeaumont michaelbeaumont merged commit e68c792 into kumahq:master Dec 15, 2023
20 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/meshroute-no-tr-route branch December 15, 2023 11:02
@crunchtime-ali crunchtime-ali mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelbeaumont @lukidzi