New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp) dedup Ingresses, small fixes #868

Merged

lobkovilya merged 2 commits into master from feat/ingress-dedup

Jun 29, 2020

Contributor

lobkovilya commented Jun 29, 2020

Summary

Deduplicate Ingress resources on the Global and small fixes.

Full changelog

Fix bug in a resilient component
Set Port for Ingress on the Global (could cause a problem with a NodePort)
Rename schema to grpc/grpcs, get rid of schema in Ingress' address

Issues resolved

Fix #XXX

Documentation

Link to the website documentation PR


          fix(kuma-cp) dedup Ingresses, small fixes

3f63c1f

lobkovilya requested a review from a team

June 29, 2020 02:04

nickolaev pushed a commit that referenced this pull request


          feat(*) change Remote/Ingress schema to grpc (imported from #868)

Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>

jakubdyszkiewicz approved these changes

View reviewed changes

Contributor

jakubdyszkiewicz left a comment •

edited

I recommend make check on git push as a hook ;)

❯❯❯ cat .git/hooks/pre-push
#!/bin/bash
make check


          fix(kuma-cp) make check

e57e00f

lobkovilya merged commit a188663 into master

nickolaev pushed a commit that referenced this pull request


          fix(kuma-cp) dedup Ingresses, small fixes (#868)

591d04d

* fix(kuma-cp) dedup Ingresses, small fixes

lobkovilya deleted the feat/ingress-dedup branch

July 29, 2020 13:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment