Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(policy): add MeshMetric policy e2e tests #8750

Merged
merged 5 commits into from Jan 8, 2024

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Jan 4, 2024

Fixes #8653

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat Automaat requested a review from a team as a code owner January 4, 2024 12:57
@Automaat Automaat requested review from bartsmykla and lukidzi and removed request for a team January 4, 2024 12:57
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@bartsmykla bartsmykla requested review from bartsmykla and removed request for bartsmykla January 8, 2024 08:43
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good, just minor things

pkg/mads/v1/service/components.go Show resolved Hide resolved
pkg/mads/v1/service/service.go Show resolved Hide resolved
test/e2e_env/kubernetes/meshmetric/meshmetric.go Outdated Show resolved Hide resolved
test/e2e_env/kubernetes/meshmetric/meshmetric.go Outdated Show resolved Hide resolved
test/e2e_env/kubernetes/meshmetric/meshmetric.go Outdated Show resolved Hide resolved
test/e2e_env/kubernetes/meshmetric/meshmetric.go Outdated Show resolved Hide resolved
test/e2e_env/kubernetes/meshmetric/meshmetric.go Outdated Show resolved Hide resolved
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat Automaat merged commit 75d22f0 into kumahq:master Jan 8, 2024
12 checks passed
@Automaat Automaat deleted the feat/meshmetric-e2e-tests branch January 8, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e tests for MeshMetric policy
2 participants