Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(proposal) proxy template redesign #877

Merged
merged 1 commit into from
Jul 6, 2020
Merged

docs(proposal) proxy template redesign #877

merged 1 commit into from
Jul 6, 2020

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Proxy Template redesign proposal

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team July 1, 2020 13:23
nickolaev
nickolaev reviewed Jul 1, 2020
View reviewed changes
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you envision having some validation of the data that the user tries to apply? If yes, is there a useful way to feedback the result of that validation to the user? In k8s this is CRD, how does the user "debug" their configuration?

nickolaev
nickolaev approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A draft of the implementation is in #883

@nickolaev nickolaev merged commit 20d4a26 into master Jul 6, 2020
@jakubdyszkiewicz jakubdyszkiewicz deleted the docs/proxy-template-redesign branch October 15, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubdyszkiewicz @nickolaev