control-plane: update local development setup #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubdyszkiewicz
approved these changes
Aug 2, 2019
| @@ -126,13 +126,21 @@ make curl/clusters | |||
|
|
|||
| 1. Start the Control Plane in your preferable choice described above | |||
|
|
|||
| 2. Start `Envoy` on local machine (requires `envoy` binary to be on your `PATH`): | |||
| 2. Build `konvoy-dataplane` | |||
There was a problem hiding this comment.
Is this step mandatory? I see that run/example/envoy will run build/konvoy-dp
There was a problem hiding this comment.
Apparently, not.
I've removed it.
yskopets
force-pushed
the
dev/local-setup
branch
from
207200f
to
f3caf5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
konvoy-dataplanein local dev setup