Update the kuma-control-plane ClusterRole to enable create/patch of kubernetes events. #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ateirney
force-pushed
the
fix/update-control-plane-cluster-role
branch
from
12b7666
to
c0987ca
Compare
The kuma-control-plane registers events that without the appropriate permissions when running on kubernetes results in the event not being recorded and an error log being generated. Fixes kumahq#815
ateirney
force-pushed
the
fix/update-control-plane-cluster-role
branch
from
c0987ca
to
5361174
Compare
|
Looks quite reasonable to me. @lobkovilya I'll wait for your approval before we merge it. |
|
Thank you for fixing it! @andrew-teirney |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the kuma-control-plane ClusterRole to enable create/patch of kubernetes events.
Full changelog
Fix the kuma-control-plane ClusterRole to enable create/patch of kubernetes events.
The kuma-control-plane registers kubernetes events that without the appropriate permissions results in the event not being recorded, and an error log being generated.
Issues resolved
Fix #815
Documentation