Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kds): fix deletion of previous zones in components #8867

Merged
merged 1 commit into from Jan 15, 2024

Conversation

lahabana
Copy link
Contributor

We were failing to delete a zone which was causing KDS to be able to work

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

We were failing to delete a zone which was causing KDS to be able to
work

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner January 15, 2024 16:44
@lahabana lahabana requested review from jijiechen, jakubdyszkiewicz and Automaat and removed request for a team January 15, 2024 16:44
@lahabana lahabana enabled auto-merge (squash) January 15, 2024 16:45
Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@lahabana lahabana merged commit 67bae7e into kumahq:master Jan 15, 2024
12 checks passed
@lahabana lahabana deleted the fixZoneCreation branch March 29, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants