feat(policy): add possibility to target only gateways/sidecars #8868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
…nto add-proxy-types-targetref
…nto add-proxy-types-targetref
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi
requested review from
jijiechen,
michaelbeaumont and
jakubdyszkiewicz
and removed request for
a team
bartsmykla
reviewed
Jan 18, 2024
pkg/plugins/policies/meshfaultinjection/api/v1alpha1/validator.go
Outdated
Show resolved
Hide resolved
pkg/plugins/policies/meshfaultinjection/api/v1alpha1/validator.go
Outdated
Show resolved
Hide resolved
bartsmykla
approved these changes
Jan 18, 2024
michaelbeaumont
requested changes
Jan 18, 2024
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
michaelbeaumont
approved these changes
Jan 18, 2024
lahabana
reviewed
Jan 19, 2024
| @@ -161,6 +168,17 @@ func resolveMeshHTTPRouteRef(refMeta core_model.ResourceMeta, refName string, mh | |||
| return nil | |||
| } | |||
|
|
|||
| func resolveDataplaneProxyType(dpp *core_mesh.DataplaneResource) common_api.TargetRefProxyType { | |||
| if dpp.Spec.GetNetworking().GetGateway() != nil { | |||
There was a problem hiding this comment.
This is broken for delegated gateway because it's technically a sidecar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
Implementation of: #8829
syscall.Mkfifohave equivalent implementation on the other OS --ci/labels to run additional/fewer testsUPGRADE.md? --