Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): set creationTime on KDS sync #8945

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

lobkovilya
Copy link
Contributor

Resource meta doesn't have creationTime after KDS sync so we can't call r.GetMeta().GetCreationTime().

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner January 22, 2024 10:31
@lobkovilya lobkovilya requested review from michaelbeaumont, slonka and jakubdyszkiewicz and removed request for a team January 22, 2024 10:31
@lobkovilya lobkovilya merged commit 7a68c4c into kumahq:master Jan 23, 2024
12 checks passed
@lobkovilya lobkovilya deleted the fix/creation-time-on-kds-sync branch January 23, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants