feat(*) statefulset support #901
Conversation
lobkovilya
force-pushed
the
feat/statefulset-support
branch
from
5f40415
to
4428ca1
Compare
| Name: inboundPassThroughClusterName, | ||
| Version: proxy.Dataplane.Meta.GetVersion(), | ||
| Resource: inboundPassThroughCluster, | ||
| }, |
There was a problem hiding this comment.
Can you help me understand why we only generate this for inbound? and why do we need old ones? Are old ones used only for outbound now?
There was a problem hiding this comment.
iptables rules redirect inbound traffic to 15006 and outbound traffic to 15001. That's why we need listeners for both ports. Both listeners send traffic to pass_through clusters, but in case 15006 it also binds connection to 127.0.0.6.
# Conflicts: # api/mesh/v1alpha1/dataplane.pb.go # pkg/xds/generator/direct_access_proxy_generator.go # pkg/xds/generator/testdata/profile-source/2-envoy-config.golden.yaml # pkg/xds/generator/testdata/profile-source/4-envoy-config.golden.yaml # pkg/xds/generator/testdata/template-proxy/1-envoy-config.golden.yaml # pkg/xds/generator/transparent_proxy_generator.go # pkg/xds/generator/transparent_proxy_generator_test.go
| Name: "catch_all", | ||
| Version: proxy.Dataplane.Meta.GetVersion(), | ||
| Resource: listener, | ||
| }, | ||
| &model.Resource{ | ||
| { | ||
| Name: "pass_through", | ||
| Version: proxy.Dataplane.Meta.GetVersion(), | ||
| Resource: cluster, | ||
| }, |
There was a problem hiding this comment.
Can we get here consistent naming for passthrough clusters? I was thing of something about:
inbound:passthrough (for listener and cluster)
outbound:passthrough (for listener and cluster)
WDYT?
There was a problem hiding this comment.
Yes, I agree. For listeners it also could be standard format: inbound:0.0.0.0:15006 and outbound:0.0.0.0:15001 to be more descriptive
There was a problem hiding this comment.
Actually will the same names for listener and cluster work? We store it in a ResourceSet, right?
There was a problem hiding this comment.
It should work because they are unique per type. I think I like this one:
listener - inbound:passthrough
cluster - inbound:passthrough
listener - outbound:passthrough
cluster - outbound:passthrough
because when browsing stats in Grafana inbound:passthrough tells me more than inbound:0.0.0.0:15006
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
|
Thanks for the fix, when will this land in a build we can use? |
|
@pauliusuza we are releasing a version this week. |
Summary
Current PR adds support of Statefulset in Kuma, which is important for example for running RabbitMQ
Full changelog
Identifierfor Dataplanes which implements headless servicesIssues resolved
Fix #844
Documentation