chore(*) prefix Kuma native tags with kuma.io
#910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 16, 2020 15:01
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
…uma_io # Conflicts: # pkg/xds/generator/testdata/outbound-proxy/03.envoy.golden.yaml # pkg/xds/generator/testdata/outbound-proxy/04.envoy.golden.yaml # pkg/xds/generator/testdata/profile-source/3-envoy-config.golden.yaml # pkg/xds/generator/testdata/profile-source/4-envoy-config.golden.yaml
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
|
This will require updates to the GUI and the docs.
…-- Marco
On Jul 20, 2020, at 8:56 PM, Nikolay Nikolaev ***@***.***> wrote:
@nickolaev requested review from @kumahq/kuma-maintainers on: #910 chore(*) prefix Kuma native tags with kuma.io as a code owner.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
The documentation PR is already linked in the description -> kumahq/kuma-website#240 @bloqhead let me know how we can align for updating the GUI. |
jakubdyszkiewicz
requested changes
Jul 21, 2020
| @@ -168,8 +168,8 @@ var _ = Describe("MonitoringAssignmentsGenerator", func() { | |||
| "dataplane": "gateway-01", | |||
| "region": "eu", | |||
| "regions": ",eu,", | |||
| "service": "gateway", | |||
| "services": ",gateway,", | |||
| "kuma_io_service": "gateway", | |||
There was a problem hiding this comment.
I'm pretty sure this will break our Grafana dashboard. Can you check it?
| @@ -130,7 +130,7 @@ resources: | |||
| safeRegexMatch: | |||
| googleRe2: | |||
| maxProgramSize: 500 | |||
| regex: .*&service=[^&]*frontend[,&].* | |||
| regex: .*&kuma.io/service=[^&]*frontend[,&].* | |||
There was a problem hiding this comment.
@lobkovilya those / won't break anything in Regexes, right?
pkg/xds/generator/testdata/profile-source/3-envoy-config.golden.yaml
Outdated
Show resolved
Hide resolved
added 7 commits
July 21, 2020 13:30
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
…uma_io Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
jakubdyszkiewicz
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relpace:
service->kuma.io/serviceprotocol->kuma.io/protocolzone->kuma.io/zoneinstance->kuma.io/instanceDocumentation