feat(kuma-cp) support for http2 #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lobkovilya
reviewed
Jul 17, 2020
| clusterBuilder := envoy_clusters.NewClusterBuilder(). | ||
| Configure(envoy_clusters.StaticCluster(localClusterName, endpoint.WorkloadIP, endpoint.WorkloadPort)) | ||
| if protocol == mesh_core.ProtocolHTTP2 { | ||
| clusterBuilder.Configure(envoy_clusters.Http2()) |
There was a problem hiding this comment.
Should it be like this?
clusterBuilder = clusterBuilder.Configure(envoy_clusters.Http2())There was a problem hiding this comment.
does not have to be, cluster builder is mutable.
lobkovilya
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Let's assume connection
This PR sets HTTP/2 by default for connections between Envoys (C2 in the above example).
It also allows to set a
protocol: http2tag for dataplane, so for example if such tag is set forbackend, the C3 will also be on http2.HTTP/2 support in Envoy can be enabled by setting
http2ProtocolOptions: {}on acluster.SSL is recommended for HTTP/2, but it's not required. Connections between Envoy works on HTTP/2 without mTLS.
If
backendis on HTTP/2 and there is no option to resign from TLS, TLS context can be configured with new ProxyTemplate modifications.Issues resolved
Fix #889
Documentation
kumahq/kuma-website#239