feat(*) move the GUI from :5683 to :5681/gui #915
Conversation
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
pkg/api-server/server.go
Outdated
| // Handle the GUI | ||
| container.Handle("/gui/", http.StripPrefix("/gui/", http.FileServer(resources.GuiDir))) | ||
| container.Handle("/api/", http.StripPrefix("/api/", container)) | ||
| container.ServeMux.HandleFunc("/gui/config/", newApiServer.configHandler) |
There was a problem hiding this comment.
I don't think /api is needed anymore. You can just invoke root path of this server. I also think that /gui/config is obsolete, because all the information are in /config
Can you coordinate this with @bloqhead on GUI side? I can help if needed.
There was a problem hiding this comment.
I also suggest API on /, while the GUI on /gui.
There was a problem hiding this comment.
I'm not opposed to using / for the API. I have to traverse up the URL path to access the API if the GUI is in /gui but that change is small. I think labeling them /api and /gui adds more clarity, but it's not crucial.
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
feat/merge_api_and_gui_servers
branch
from
60517e5
to
6babf7e
Compare
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
…gui_servers Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
…gui_servers # Conflicts: # app/kumactl/pkg/install/k8s/control-plane/templates_vfsdata.go
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
|
Just want to confirm that API listens on |
pkg/api-server/server_gui_test.go
Outdated
| } | ||
|
|
||
| Describe("enabled", | ||
| func() { |
There was a problem hiding this comment.
nit: we put it in the same line with describe
pkg/api-server/server_gui_test.go
Outdated
| var stop chan struct{} | ||
| var baseUrl string | ||
|
|
||
| beforeEach := func(enabelGUI bool) { |
There was a problem hiding this comment.
how about setupServer instead of beforeEach
pkg/api-server/server.go
Outdated
| @@ -31,7 +35,8 @@ var ( | |||
| ) | |||
|
|
|||
| type ApiServer struct { | |||
| server *http.Server | |||
| server *http.Server | |||
| GuiServerConfig *gui_server.GuiServerConfig | |||
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Exactly, there are no other endpoints from the old GUI server. |
|
Is there anything else we have left on this task? I have the changes in place in the GUI to align with this. |
…gui_servers Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Summary
Changes:
:5683:5681/guiremotemode), show a disabled pageIssues resolved
Fix #XXX
Documentation