Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): downgrade go-control-plane to v0.11.2-0.20231010133108-1dfbe83bcebc #9163

Merged
merged 2 commits into from Feb 7, 2024
Merged

chore(deps): downgrade go-control-plane to v0.11.2-0.20231010133108-1dfbe83bcebc #9163

merged 2 commits into from Feb 7, 2024

Conversation

lobkovilya
Copy link
Contributor

While the envoyproxy/go-control-plane#875 is not resolved we need a way to stabilize the CI.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lobkovilya
chore(deps): downgrade go-control-plane to avoid test flakes due to d…
032c7e0 
…eadlocks

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore(deps): make check
b683412 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner February 7, 2024 15:31
@lobkovilya lobkovilya requested review from jijiechen, Automaat and lukidzi and removed request for a team February 7, 2024 15:31
@lobkovilya lobkovilya enabled auto-merge (squash) February 7, 2024 15:43
@lobkovilya lobkovilya merged commit 5299ab6 into kumahq:master Feb 7, 2024
12 checks passed
@lobkovilya lobkovilya deleted the chore/downgrade-go-control-plane branch February 7, 2024 16:16
@lukidzi lukidzi mentioned this pull request Feb 13, 2024
Closed
@lobkovilya lobkovilya added this to the 2.6.x milestone Feb 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited

backporting to release-2.3 with action

backporting to release-2.4 with action
backporting to release-2.5 with action
backporting to release-2.6 with action

@github-actions GitHub Actions
Copy link
Contributor

backporting to release-2.2 with action

kumahq bot pushed a commit that referenced this pull request Feb 15, 2024
@lobkovilya @kumahq
chore(deps): downgrade go-control-plane to v0.11.2-0.20231010133108-1…
0453bb6 
…dfbe83bcebc (#9163)

* chore(deps): downgrade go-control-plane to avoid test flakes due to deadlocks

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@kumahq kumahq bot mentioned this pull request Feb 15, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Feb 15, 2024
@lobkovilya @kumahq
chore(deps): downgrade go-control-plane to v0.11.2-0.20231010133108-1…
99aaba6 
…dfbe83bcebc (#9163)

* chore(deps): downgrade go-control-plane to avoid test flakes due to deadlocks

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@kumahq kumahq bot mentioned this pull request Feb 15, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Feb 15, 2024
@lobkovilya @kumahq
chore(deps): downgrade go-control-plane to v0.11.2-0.20231010133108-1…
7b8ff69 
…dfbe83bcebc (#9163)

* chore(deps): downgrade go-control-plane to avoid test flakes due to deadlocks

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@kumahq kumahq bot mentioned this pull request Feb 15, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Feb 15, 2024
@lobkovilya @kumahq
chore(deps): downgrade go-control-plane to v0.11.2-0.20231010133108-1…
f0b507b 
…dfbe83bcebc (#9163)

* chore(deps): downgrade go-control-plane to avoid test flakes due to deadlocks

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@kumahq kumahq bot mentioned this pull request Feb 15, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Feb 15, 2024
@lobkovilya @kumahq
chore(deps): downgrade go-control-plane to v0.11.2-0.20231010133108-1…
f8de145 
…dfbe83bcebc (#9163)

* chore(deps): downgrade go-control-plane to avoid test flakes due to deadlocks

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@kumahq kumahq bot mentioned this pull request Feb 15, 2024
Merged
lobkovilya pushed a commit that referenced this pull request Feb 15, 2024
@kumahq
chore(deps): downgrade go-control-plane to v0.11.2-0.20231010133108-1…
4650129 
…dfbe83bcebc (backport of #9163) (#9285)

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya mentioned this pull request Mar 12, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
2.6.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lobkovilya @jakubdyszkiewicz