Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-server): add type filter to service-insights #9212

Merged
merged 1 commit into from Feb 13, 2024

Conversation

lahabana
Copy link
Contributor

works with ?type=internal,gateway_builtin
migrate all serviceInsights tests to table test with input and output

Fix #9109

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

works with `?type=internal,gateway_builtin`
migrate all serviceInsights tests to table test with input and output

Fix kumahq#9109

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner February 12, 2024 17:06
@lahabana lahabana requested review from michaelbeaumont, jakubdyszkiewicz and lukidzi and removed request for a team February 12, 2024 17:06
@lahabana lahabana merged commit 0a968ba into kumahq:master Feb 13, 2024
12 checks passed
@lahabana lahabana deleted the fix9109 branch February 13, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add serviceType filter parameter to /service-insights endpoint(s)
2 participants