fix(kuma-cp) Fix Empty Labels on kuma-cp pod converter #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tharun208 thanks! can you write a test case for it? |
Fixed InboudTagsFor to remove empty labels and ignore it Added tests Fixes kumahq#753 Signed-off-by: Tharun <rajendrantharun@live.com>
tharun208
force-pushed
the
fix/kuma-cp-tag-empty
branch
from
13ce459
to
97b34c3
Compare
jakubdyszkiewicz
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed InboudTagsFor to remove empty labels and ignore it
Fixes #753
Signed-off-by: Tharun rajendrantharun@live.com