Dynamic tracing #930
Merged
Dynamic tracing #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
approved these changes
Jul 28, 2020
| @@ -31,3 +31,7 @@ func GetEnvoyAdminClusterName() string { | |||
| func GetPrometheusListenerName() string { | |||
| return "kuma:metrics:prometheus" | |||
| } | |||
|
|
|||
| func GetTracingCluster(backendName string) string { | |||
There was a problem hiding this comment.
GetTracingClusterName in order to be consistent with the whole other file
| switch c := cluster.(type) { | ||
| case *framework.K8sCluster: | ||
| deployment := &k8SDeployment{} | ||
| c.Deployments[DeploymentName] = deployment |
There was a problem hiding this comment.
I don't really like these direct writes to the map. Can we extend framework.Deployment interface with a new method Name() string and add a new method to framework.Cluster interfaces:
func (c *K8sCluster) Deploy(d Deployment) error {
c.deployment[d.Name()] = d
return d.Deploy(c)
}
nickolaev
approved these changes
Jul 28, 2020
| envoy_endpoints "github.com/kumahq/kuma/pkg/xds/envoy/endpoints" | ||
| ) | ||
|
|
||
| func DNSCluster(name string, address string, port uint32) ClusterBuilderOpt { |
There was a problem hiding this comment.
Is that only for the Dynamic tracing, or it will allow to use DNS names in other filters too?
There was a problem hiding this comment.
Maybe in the future, but for now - not really. There are several cluster types:
- EDS cluster - most commonly used, it relies on ClusterLoadAssignment on endpoints which cannot be DNS names.
- Static cluster - it requires static endpoints that are IPs. It is used only for inbound cluster (which IP we know from DP definition and it should be IP because it is then used in outbounds of other DPs) and Prometheus (admin IP)
- original dst - transparent proxy
- strict DNS - used here since an address can be a DNS name.
| @@ -45,7 +47,7 @@ spec: | |||
| - -e | |||
| - echo | |||
| - -e | |||
| - "HTTP/1.1 200 OK" | |||
| - "HTTP/1.1 200 OK\n\n" | |||
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kuma now leverages tracing configuration on HTTP Connection Manager introduced in Envoy 1.15.
Testing
I added E2E test to check if traces are sent to Jeager on Universal and Kubernetes.
To avoid polluting
Clusterinterface with even more methods I introduced the concept ofDeployment.Deploymentis work unit that can be deployed onClusterand it exposes user friendly interface for testing. So for example for tracing it'sTracedService()andZipkinCollectorURL(). I believe that Kuma CP, Kuma DP, demo app, demo client should all be deployments, so for example demo client it could beso you don't have to look for pods/containers and construct curls.
Tests should be as simple as possible to read.
Documentation