Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(k8s): sidecar containers #9321

Merged
merged 12 commits into from Feb 22, 2024
Merged

feat(k8s): sidecar containers #9321

merged 12 commits into from Feb 22, 2024

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Feb 20, 2024 •
edited

This PR adds a .experimental config flag. The feature isn't really experimental but it shouldn't be the default yet since the feaure is still beta.
It adds a new job to the matrix that runs the Kubernetes tests with the features enabled.
Question: Do we think it's ok that it runs only on master or should it be run on PRs?

Note: all the added lines are the golden files for injector tests with sidecars enabled.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues -- Closes add support for k8s sidecar-containers #7541
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Feb 20, 2024
@michaelbeaumont michaelbeaumont force-pushed the feat/sidecar branch 3 times, most recently from 3352850 to ccc1ed2 Compare February 20, 2024 17:03
@michaelbeaumont
feat(k8s): sidecar containers
f5bb4d9 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(e2e_env): adjust container patch e2e test
c3d5fc8 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the feat/sidecar branch 3 times, most recently from 6f5ffc4 to 21c005b Compare February 21, 2024 12:05
@michaelbeaumont
feat(kuma-cp): add experimental config for sidecar containers
653fd37 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the feat/sidecar branch 2 times, most recently from e1cec89 to e7d7b49 Compare February 21, 2024 12:31
michaelbeaumont
michaelbeaumont commented Feb 21, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@michaelbeaumont
test(injector): add unit test for sidecar feature
d4f3afa 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
ci: add job for sidecar container feature
494a194 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
Merge remote-tracking branch 'upstream/master' into feat/sidecar
51d30cb 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review February 21, 2024 16:34
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner February 21, 2024 16:34
@michaelbeaumont michaelbeaumont requested review from slonka, jakubdyszkiewicz and lobkovilya and removed request for a team February 21, 2024 16:34
@michaelbeaumont
ci(.circleci): only run sidecar containers feature job on master
a48e144 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
ci: don't support sidecar containers on circleci
5b6255d 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
Merge branch 'master' into feat/sidecar
ec5d194 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@slonka
Copy link
Contributor

slonka commented Feb 22, 2024

CI seems to not be running. I'll do "update branch" to see if that triggers a that.

@slonka
Copy link
Contributor

slonka commented Feb 22, 2024

That helped.

@michaelbeaumont
refactor: expose two explicit functions
3e68080 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: add warning if feature enabled but not supported
f83219a 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit 80c150e into kumahq:master Feb 22, 2024
33 checks passed
@michaelbeaumont michaelbeaumont deleted the feat/sidecar branch February 22, 2024 13:11
@BrewTestBot BrewTestBot mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz

@lahabana lahabana Awaiting requested review from lahabana

Assignees
No one assigned
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for k8s sidecar-containers
4 participants
@michaelbeaumont @slonka @lahabana @jakubdyszkiewicz