feat(kuma-cp) e2e stabilization #939
Conversation
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
| _, stderr, err := c1.ExecWithRetries(TestNamespace, clientPod.GetName(), "demo-client", | ||
| "curl", "-v", "-m", "3", "echo-server") | ||
| return stderr, err | ||
| }, "10s", "1s").Should(ContainSubstring("HTTP/1.1 200 OK")) |
There was a problem hiding this comment.
shall we use the default for the timeouts/
There was a problem hiding this comment.
Can we retry if not 200 OK returned?
There was a problem hiding this comment.
Eventually + ExecWithRetries
Can we have single code for retries?
There was a problem hiding this comment.
Can we retry if not 200 OK returned?
@nickolaev I'm sorry, not sure that I'm following here. It will retry until a response contains HTTP/1.1 200 OK
There was a problem hiding this comment.
@jakubdyszkiewicz I believe ExecWithRetries should be named just Exec. These retries are needed to exec command with status code equals 0. And eventually is needed to check that response itself is correct
There was a problem hiding this comment.
Oh actually it is OK. Please ignore.
There was a problem hiding this comment.
I am tempted to have "CurlWithRetries" :)
|
e2e passes - merging this one. |
Signed-off-by: Ilya Lobkov ilya.lobkov@konghq.com
Summary
Policies might take some short period of time to be applied and propagated to Envoy. That's why all
curlchecks have to be done usingEventually