chore(*) parametrize makefiles and tools #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
approved these changes
Jul 31, 2020
| .PHONY: test | ||
| test: ${COVERAGE_PROFILE} test/api test/k8s test/kuma coverage ## Dev: Run tests for all modules | ||
| test: ${COVERAGE_PROFILE} ## Dev: Run tests for all modules |
There was a problem hiding this comment.
I believe you can just do:
test: ${COVERAGE_PROFILE} ${TEST_TARGETS} coveragewithout for-loop
There was a problem hiding this comment.
Nope, that does not work. Ping me offline to explain, but essentially when there is invocation to the same target within a single make execution, it will not execute the target only once.
There was a problem hiding this comment.
The trick is that you can't. Current implementation did not run test/k8s because test/module target was already run with test/api
nickolaev
reviewed
Jul 31, 2020
nickolaev
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parametrize makefiles and tools for more flexibility of running it.