Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MeshHTTPRoute): order rules by match priority #9472

Merged
merged 9 commits into from Mar 6, 2024
Merged

fix(MeshHTTPRoute): order rules by match priority #9472

merged 9 commits into from Mar 6, 2024

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Mar 1, 2024 •
edited

Checklist prior to review

@michaelbeaumont michaelbeaumont force-pushed the fix/mhr-order branch 2 times, most recently from 4bf2d83 to 47c601d Compare March 1, 2024 12:59
@michaelbeaumont
test(MeshHTTPRoute): add match priority case
a928dd2 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the fix/mhr-order branch 2 times, most recently from c1c8303 to 08ca841 Compare March 5, 2024 14:35
@michaelbeaumont
feat(MeshHTTPRoute): order rules by matches
99ae695 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(MeshHTTPRoute): update expected order
ddb15e6 
Hashes are updated because we no longer hash the "catch all" path that
may be added in listeners.go for Envoy reasons.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(MeshHTTPRoute): add compare tests
16c3cdf 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review March 5, 2024 15:56
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner March 5, 2024 15:56
@michaelbeaumont michaelbeaumont requested review from slonka and jakubdyszkiewicz and removed request for a team March 5, 2024 15:56
@michaelbeaumont
refactor: comparePath
ff0718a 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
refactor: compareHeaders, compareQueryParams
8fba6f0 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: add note about regex matches
6247606 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test(MeshHTTPRoute): add test cases
4b2cc8a 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
Merge remote-tracking branch 'upstream/master' into fix/mhr-order
5ea9094 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit 3310847 into kumahq:master Mar 6, 2024
21 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/mhr-order branch March 6, 2024 20:58
@bartsmykla bartsmykla mentioned this pull request Apr 9, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@lukidzi lukidzi lukidzi approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort MeshHTTPRoute for kind: MeshService according to Gateway API rules
3 participants
@michaelbeaumont @lahabana @lukidzi