New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MeshService): add first iteration of resource #9510
Merged
michaelbeaumont
merged 6 commits into
kumahq:master
from
michaelbeaumont:feat/meshservice-gen
Mar 13, 2024
Merged
feat(MeshService): add first iteration of resource #9510
michaelbeaumont
merged 6 commits into
kumahq:master
from
michaelbeaumont:feat/meshservice-gen
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
force-pushed
the
feat/meshservice-gen
branch
2 times, most recently
from
March 7, 2024 11:53
be036ad
to
4d46a8a
Compare
michaelbeaumont
requested review from
jakubdyszkiewicz,
lobkovilya and
lukidzi
and removed request for
a team
March 7, 2024 12:46
michaelbeaumont
force-pushed
the
feat/meshservice-gen
branch
5 times, most recently
from
March 8, 2024 14:34
52763a5
to
43008d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The moment you merge it. It becomes available in mink.
Core policies were not meant to be disabled, because well... those are core policies. We need to place some guard for now to not register it in Mink.
michaelbeaumont
force-pushed
the
feat/meshservice-gen
branch
from
March 12, 2024 08:24
43008d2
to
0545818
Compare
lahabana
reviewed
Mar 12, 2024
pkg/core/resources/apis/meshservice/api/v1alpha1/meshservice.go
Outdated
Show resolved
Hide resolved
lahabana
reviewed
Mar 12, 2024
lahabana
reviewed
Mar 12, 2024
michaelbeaumont
force-pushed
the
feat/meshservice-gen
branch
2 times, most recently
from
March 12, 2024 14:16
1547c40
to
fe51ec7
Compare
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/meshservice-gen
branch
from
March 12, 2024 14:19
fe51ec7
to
18f54ab
Compare
jakubdyszkiewicz
approved these changes
Mar 12, 2024
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont
changed the title
feat(MeshService): add skeleton resource
feat(MeshService): add first iteration of resource
Mar 12, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --