Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MeshService): add first iteration of resource #9510

Merged
merged 6 commits into from Mar 13, 2024

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Mar 6, 2024

  • helm chart changes

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont michaelbeaumont force-pushed the feat/meshservice-gen branch 2 times, most recently from be036ad to 4d46a8a Compare March 7, 2024 11:53
@michaelbeaumont michaelbeaumont marked this pull request as ready for review March 7, 2024 12:46
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner March 7, 2024 12:46
@michaelbeaumont michaelbeaumont requested review from jakubdyszkiewicz, lobkovilya and lukidzi and removed request for a team March 7, 2024 12:46
@michaelbeaumont michaelbeaumont force-pushed the feat/meshservice-gen branch 5 times, most recently from 52763a5 to 43008d2 Compare March 8, 2024 14:34
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The moment you merge it. It becomes available in mink.
Core policies were not meant to be disabled, because well... those are core policies. We need to place some guard for now to not register it in Mink.

@michaelbeaumont michaelbeaumont force-pushed the feat/meshservice-gen branch 2 times, most recently from 1547c40 to fe51ec7 Compare March 12, 2024 14:16
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont changed the title feat(MeshService): add skeleton resource feat(MeshService): add first iteration of resource Mar 12, 2024
@michaelbeaumont michaelbeaumont merged commit 5325d9d into kumahq:master Mar 13, 2024
22 checks passed
@michaelbeaumont michaelbeaumont deleted the feat/meshservice-gen branch March 13, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants