Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gui) default the API Server to request URL minus "/gui" #963

Merged
merged 4 commits into from
Aug 12, 2020

Conversation

nickolaev
Copy link
Contributor

@nickolaev nickolaev commented Aug 11, 2020

Signed-off-by: Nikolay Nikolaev nikolay.nikolaev@konghq.com

Summary

Make kuma-gui API server to default to request URL minus "/gui"

Issues resolved

Fix #943

Imports the changes from kumahq/kuma-gui#54

Tested with Kong Ingress as follows:

$  kubectl apply -f https://bit.ly/k4k8s

$  echo '
  apiVersion: networking.k8s.io/v1beta1
  kind: Ingress
  metadata:
    name: demo
    namespace: kuma-system
    annotations:
      konghq.com/strip-path: "true"
  spec:
    rules:
      - http:
          paths:
            - path: /
              backend:
                serviceName: kuma-control-plane
                servicePort: 5681
    ' | kubectl apply -f -


$  echo '
  apiVersion: networking.k8s.io/v1beta1
  kind: Ingress
  metadata:
    name: demo
    namespace: kuma-system
    annotations:
      konghq.com/strip-path: "false"
  spec:
    rules:
      - http:
          paths:
            - path: /config
              backend:
                serviceName: kuma-control-plane
                servicePort: 5681
    ' | kubectl apply -f -

Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
@nickolaev nickolaev requested a review from a team as a code owner August 11, 2020 09:01
Nikolay Nikolaev added 3 commits August 11, 2020 18:53
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
@nickolaev nickolaev changed the title fix(gui) default the API Server URL to "/" fix(gui) default the API Server to request URL minus "/gui" Aug 12, 2020
@nickolaev nickolaev merged commit ab5745f into master Aug 12, 2020
@nickolaev nickolaev deleted the fix/gui_remote branch August 13, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: kuma-gui support only localhost?
2 participants