Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MeshMetric): otel endpoint validation #9634

Merged
merged 1 commit into from Mar 18, 2024

Conversation

Automaat
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat Automaat requested a review from a team as a code owner March 18, 2024 08:36
@Automaat Automaat requested review from jijiechen, michaelbeaumont and bartsmykla and removed request for a team March 18, 2024 08:36
@Automaat Automaat merged commit 48ccdc9 into kumahq:master Mar 18, 2024
15 checks passed
@Automaat Automaat deleted the improve-otel-endpoint-validation branch March 18, 2024 09:13
@lahabana lahabana changed the title fix(policy): fix otel endpoint validation for meshmetric fix(MeshMetric): fix otel endpoint validation Apr 11, 2024
@lahabana lahabana changed the title fix(MeshMetric): fix otel endpoint validation fix(MeshMetric): otel endpoint validation Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants