Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MeshHTTPRoute): fix response headers filter in gateway route generation #9652

Merged
merged 1 commit into from Mar 19, 2024
Merged

fix(MeshHTTPRoute): fix response headers filter in gateway route generation #9652

merged 1 commit into from Mar 19, 2024

Conversation

bartsmykla
Copy link
Contributor

Bug found when run gateway api conformance tests with MeshHTTPRoute instead of MeshGatewayRoute internally.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
    • No relevant issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • It won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Added
    • Tested manually
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md?
    • There is no need
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • It does

@bartsmykla
fix(MeshHTTPRoute): fix response headers filter in gateway route gene…
8f3e6a8 
…ration

Bug found when run gateway api conformance tests with MeshHTTPRoute
instead of MeshGatewayRoute internally.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested a review from a team as a code owner March 19, 2024 07:42
@bartsmykla bartsmykla requested review from jijiechen and Automaat and removed request for a team March 19, 2024 07:42
@bartsmykla bartsmykla enabled auto-merge (squash) March 19, 2024 07:44
@bartsmykla bartsmykla merged commit c579544 into kumahq:master Mar 19, 2024
17 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024 •
edited

backporting to release-2.2 with action

backporting to release-2.3 with action
backporting to release-2.6 with action
backporting to release-2.5 with action

@github-actions GitHub Actions
Copy link
Contributor

backporting to release-2.4 with action

kumahq bot pushed a commit that referenced this pull request Mar 19, 2024
@bartsmykla @kumahq
fix(MeshHTTPRoute): fix response headers filter in gateway route gene…
34908d2 
…ration (#9652)

Bug found when run gateway api conformance tests with MeshHTTPRoute
instead of MeshGatewayRoute internally.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@kumahq kumahq bot mentioned this pull request Mar 19, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Mar 19, 2024
@bartsmykla @kumahq
fix(MeshHTTPRoute): fix response headers filter in gateway route gene…
6351362 
…ration (#9652)

Bug found when run gateway api conformance tests with MeshHTTPRoute
instead of MeshGatewayRoute internally.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@kumahq kumahq bot mentioned this pull request Mar 19, 2024
Closed
@bartsmykla bartsmykla deleted the fix/response-header-filter-in-meshhttproute-gateway-route-generation branch March 19, 2024 10:24
kumahq bot pushed a commit that referenced this pull request Mar 19, 2024
@bartsmykla @kumahq
fix(MeshHTTPRoute): fix response headers filter in gateway route gene…
eeb048b 
…ration (#9652)

Bug found when run gateway api conformance tests with MeshHTTPRoute
instead of MeshGatewayRoute internally.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@kumahq kumahq bot mentioned this pull request Mar 19, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Mar 19, 2024
@bartsmykla @kumahq
fix(MeshHTTPRoute): fix response headers filter in gateway route gene…
94fe38e 
…ration (#9652)

Bug found when run gateway api conformance tests with MeshHTTPRoute
instead of MeshGatewayRoute internally.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@kumahq kumahq bot mentioned this pull request Mar 19, 2024
Merged
kumahq bot pushed a commit that referenced this pull request Mar 19, 2024
@bartsmykla @kumahq
fix(MeshHTTPRoute): fix response headers filter in gateway route gene…
5f00c98 
…ration (#9652)

Bug found when run gateway api conformance tests with MeshHTTPRoute
instead of MeshGatewayRoute internally.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@kumahq kumahq bot mentioned this pull request Mar 19, 2024
Closed
bartsmykla added a commit that referenced this pull request Mar 20, 2024
@kumahq @bartsmykla
fix(MeshHTTPRoute): fix response headers filter in gateway route gene…
8b3fa1c 
…ration (backport of #9652) (#9660)

fix(MeshHTTPRoute): fix response headers filter in gateway route generation (#9652)

Bug found when run gateway api conformance tests with MeshHTTPRoute
instead of MeshGatewayRoute internally.

Signed-off-by: Bart Smykla <bartek@smykla.com>
Co-authored-by: Bart Smykla <bartek@smykla.com>
@BrewTestBot BrewTestBot mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartsmykla @michaelbeaumont @jakubdyszkiewicz