Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MeshService): backend ref outbound to mesh service on Dataplane #9653

Merged
merged 2 commits into from Mar 25, 2024

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Mar 19, 2024

Checklist prior to review

Adds a way to address MeshService using outbound (non-transparent proxy). I also moved generating ServiceDestination based on MeshService from httproute to build implicit outbound (just like we do for VIPs). This makes the code consistent.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Mar 19, 2024
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review March 20, 2024 13:01
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner March 20, 2024 13:01
@jakubdyszkiewicz jakubdyszkiewicz requested review from jijiechen, Automaat and bartsmykla and removed request for a team March 20, 2024 13:01
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz removed the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Mar 25, 2024
@jakubdyszkiewicz jakubdyszkiewicz merged commit d6b7a35 into kumahq:master Mar 25, 2024
35 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the outbound-backend-ref branch March 25, 2024 14:51
@lahabana lahabana changed the title feat(dataplane): backend ref outbound to mesh service feat(MeshService): backend ref outbound to mesh service on dataplane object Apr 11, 2024
@lahabana lahabana changed the title feat(MeshService): backend ref outbound to mesh service on dataplane object feat(MeshService): backend ref outbound to mesh service on Dataplane Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants