Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kds): stats of kds client versions #9749

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

This PR adds stats of number of clients per version. For now it only works with Delta KDS, but I added this to generic stats callbacks so in the future we can add this to other DSes if we want to.

I considered just adding a dimension to _streams_active metric, but streams active counts all DS streams, whereas this metric only counts streams with at least one DiscoveryRequest, because version is carried in metadata of request. This should be equal, but technically can be different.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner March 28, 2024 14:42
@jakubdyszkiewicz jakubdyszkiewicz requested review from Automaat, lobkovilya and lukidzi and removed request for a team March 28, 2024 14:42
pkg/util/xds/stats_callbacks.go Outdated Show resolved Hide resolved
pkg/util/xds/stats_callbacks.go Show resolved Hide resolved
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit 68d5610 into kumahq:master Apr 2, 2024
15 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/kds-stats-versions branch April 2, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants