feat(kds): stats of kds client versions #9749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
This PR adds stats of number of clients per version. For now it only works with Delta KDS, but I added this to generic stats callbacks so in the future we can add this to other DSes if we want to.
I considered just adding a dimension to
_streams_active
metric, but streams active counts all DS streams, whereas this metric only counts streams with at least one DiscoveryRequest, because version is carried in metadata of request. This should be equal, but technically can be different.syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --