feat(kuma-cp) validate zone location apply #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nickolaev
reviewed
Aug 18, 2020
| @@ -36,7 +36,6 @@ rules: | |||
| - update | |||
| - patch | |||
| - delete | |||
| {{- if eq .KumaCpMode "global" }} | |||
There was a problem hiding this comment.
Hmm, how safe is to remove this restriction?
There was a problem hiding this comment.
Safe. We need to have CRD+permissions to apply Zone on standalone/remote to actually throw a validation error
…alidation Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nickolaev
reviewed
Aug 21, 2020
…alidation Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
approved these changes
Aug 24, 2020
| @@ -134,6 +139,24 @@ func isDefaultMesh(resType core_model.ResourceType, obj k8s_model.KubernetesObje | |||
| return resType == core_mesh.MeshType && obj.GetName() == core_model.DefaultMesh && len(obj.GetSpec()) == 0 | |||
| } | |||
|
|
|||
| // validateResourceLocation validates if resources that supouse to be applied on Global are applied on Global and other way around | |||
There was a problem hiding this comment.
I'll fix it in the next PR
nickolaev
pushed a commit
that referenced
this pull request
Oct 1, 2020
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds validation of applying Zone on standalone/remote