feat(k8s): do not set mesh owner reference on synced resources #9882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
I investigated KDS NACKs in E2E tests and all of them are caused by mesh owner reference.
What is interesting is that we don't set Mesh owner reference on Universal (because we go directly thorough store, not resource manager), that's why the only NACKs we saw were from Kube zones.
Setting mesh owner reference caused the following problems:
Additionally, I disabled secret delete validation on synced resources. This also caused a race when you delete Secret before Mesh. It was also only applied on Kube because of same reasons (store vs manager).
After this change, I see 0 NACKs on KDS in the multizone suite.
Also, first I tried ordering resources over KDS, but not waiting for ACK resulted races as well. I think it's just more correct to trust the source of truth (other CP that manages resource).
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --