Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentracing api #3

Open
caiquecastanho opened this issue Aug 18, 2020 · 0 comments
Open

Update opentracing api #3

caiquecastanho opened this issue Aug 18, 2020 · 0 comments

Comments

@caiquecastanho
Copy link

I'd like to update the open tracing api's version to 0.33.0 in order to use opentracing-contrib/java-apache-httpclient.

I've took a look at the code to find out what I should update and I've found these ones:

  • pom.xml
-        <opentracing.version>0.31.0</opentracing.version>
+        <opentracing.version>0.33.0</opentracing.version>
         <opentracing-concurrent.version>0.2.0</opentracing-concurrent.version>
-        <jaeger.version>0.33.1</jaeger.version>
+        <jaeger.version>1.3.2</jaeger.version>
  • com.kumuluz.ee.opentracing.filters.OpenTracingServerRequestFilter
             requestContext.setProperty(CommonUtil.OPENTRACING_SPAN_TITLE,
spanBuilder.startActive(true).span());
  • core/src/main/java/com/kumuluz/ee/opentracing/interceptors/TracedInterceptor.java
try (Scope scope = tracer.buildSpan(operationName).asChildOf(parentSpan).startActive(true))

According to the opentracing documentation: ScopeManager.active(Span, boolean) and SpanBuilder.startActive() have been deprecated as part of removing automatic Span finish upon Scope close...

Is there any more code I need to update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant