Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You should get your theme enlisted with spacemacs #20

Closed
kksharma1618 opened this issue May 23, 2020 · 1 comment
Closed

You should get your theme enlisted with spacemacs #20

kksharma1618 opened this issue May 23, 2020 · 1 comment

Comments

@kksharma1618
Copy link

Hey,

Currently to make it work permanently, I had to update one of their config file which maps chosen theme (at startup) to the package from which it was installed from.
image

Basically they allow you to set theme variable in ~/.spacemacs file

   dotspacemacs-themes '(poet-dark
                         spacemacs-dark
                         spacemacs-light)

The first entry is chosen as default one. But theme has to match a package, otherwise they try to install it by suffixing it with "-theme". When I added "poet-dark" to dotspacemacs-themes variable it kept installing "poet-dark-theme" package. "poet" worked fine (as your package name is "poet-theme").

So I had to update their config file which maps theme to package at ~/.emacs.d/core/core-themes-support.el
And add entry for "poet-dark" to map to "poet-theme" as shown in screenshot. You can probably send them a pr to add your theme to their config file. I saw they did it for https://github.com/thblt/eziam-theme-emacs

Thanks for this theme btw. My favorite theme for emacs :)

kunalb added a commit to kunalb/spacemacs that referenced this issue May 31, 2020
Someone requested this at kunalb/poet#20. 

I'm not sure if this is only for themes that are shipped with spacemacs or themes in general, but I thought I'd send out the diff to ask :)
kunalb added a commit to kunalb/spacemacs that referenced this issue May 31, 2020
Someone requested adding poet's variants to the theme -> package mapping in spacemacs at kunalb/poet#20.
smile13241324 pushed a commit to syl20bnr/spacemacs that referenced this issue Jun 7, 2020
Someone requested adding poet's variants to the theme -> package mapping in spacemacs at kunalb/poet#20.
@smile13241324
Copy link

Merged into Spacemacs.

@kunalb kunalb closed this as completed Jun 7, 2020
aam-at pushed a commit to aam-at/spacemacs that referenced this issue Mar 23, 2021
Someone requested adding poet's variants to the theme -> package mapping in spacemacs at kunalb/poet#20.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants