Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tightenco/collect composer version #136

Closed
wants to merge 1 commit into from

Conversation

monro93
Copy link

@monro93 monro93 commented Sep 10, 2018

Hi,
Related with this issue of tightenco/collect, the version 5.7.1 is throwing a warning and crashing in some circustances (running test for instance), to fix that we just have to fix the version to 5.6. I hope that you can merge this PR.

Thanks and Regards.

@mattstauffer
Copy link

mattstauffer commented Sep 10, 2018

For more info, collect 5.7.1 has a bug. It’s fixed in 5.7.2 but that version introduces a dependency of the Symfony Var Dumper @4.1.

If your app or package can’t support 4.1 var dumper, the best option is require Collect less than 5.7.0.

One option would be for individuals in this circumstance to manually require collect at a fixed 5.6.* version into their app, would would make Dropbox sdk just use that version. So hopefully we can find a solution that actually doesn’t require packages like this one to change their constraints.

I’m open to any other ideas or suggestions as well.

@hyncica
Copy link

hyncica commented Sep 10, 2018

This package doesn't require symfony/var-dumper and it can be installed with Collect 5.7.2. So i don't think that it's good idea to restrict Collect's require to version 5.6.*. The version limitation from monro93's issue is probably caused by some other package.

@monro93
Copy link
Author

monro93 commented Sep 10, 2018

Yes, you are right, it's another package but it's symfony/symfony 3.4, it's true that is not the last version of symfony but there is support for it until 2020. If there is not another option I will fix the version to 5.6.* in the composer of all my applications that use your library but I think that is not a very nice solution.

Thanks

@hyncica
Copy link

hyncica commented Sep 10, 2018

I'm not an author of this package.

IMHO If you are using symfony 3.4 then you should limit version of Collect in your applications. It's still better solution than forcing your limitations for everyone using this package.

@mattstauffer
Copy link

I've just pushed out a release of Collect (5.7.3) that should solve this issue; it allows for folks using Var-dumper back to 3.4 to use the up-to-date versions of Collect.

@monro93
Copy link
Author

monro93 commented Sep 14, 2018

Perfect, thanks @mattstauffer we can close this :)

@monro93 monro93 closed this Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants