Fix: Android url prefixing #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was changed in commit d8a3edf
kiwi-josh
added a commit
to htdc/cordova-plugin-second-webview
that referenced
this pull request
Sep 6, 2018
arturokunder
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #43
During the 2.6->2.7 transition, the url-prefixing regex in
WebViewActivity.javawas refactored: two globbing operators (*) were removed, causing much more aggressive prefixing. This seems unintentional: the commit - d8a3edf introduced additional prefixing for the encrypted-file feature.URL examples
https://remote.com/cordova.html- previously no prefixing, now prefixed tofile:///android_asset/www/https://remote.com/cordova.htmljavascript:alert(1)- previously no prefixing, now prefixed tofile:///android_asset/www/javascript:alert(1)This PR restores the regex to it's
v2.6.0functionality.