Add outputs and resolve checkov scans

[kunduso]

This PR closes #32 by adding outputs to the infra terraform stack. These outputs are required for the higher level deploy stack to deploy the aws_ecs_service and aws_ecs_task_definition resources.

[github-actions]

Infracost report

💰 Monthly cost will not change

Cost details

──────────────────────────────────
The following projects have no cost estimate changes: kunduso/add-aws-ecr-ecs-fargate/infra/TFplan.JSON
Run the following command to see their breakdown: infracost breakdown --path=/path/to/code

──────────────────────────────────
34 cloud resources were detected:
∙ 7 were estimated
∙ 25 were free
∙ 2 are not supported yet, see https://infracost.io/requested-resources:
  ∙ 1 x aws_kms_key_policy
  ∙ 1 x aws_service_discovery_http_namespace

_{This comment will be updated when code changes.}

[github-actions]

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Plan 📖success

Terraform Validation 🤖success

Show Plan

terraform
data.aws_caller_identity.current: Reading...
aws_service_discovery_http_namespace.namespace: Refreshing state... [id=ns-ufwgav2zprjdgapp]
aws_kms_key.app_4_key: Refreshing state... [id=4b7905a0-b2d6-46dd-9db8-d1211429cda3]
aws_vpc.this: Refreshing state... [id=vpc-03206654adef9668d]
data.aws_caller_identity.current: Read complete after 0s [id=743794601996]
aws_kms_alias.key: Refreshing state... [id=alias/app-4]
aws_cloudwatch_log_group.logs: Refreshing state... [id=/amazon-ecs/app-4/log]
aws_ecr_repository.image_repo: Refreshing state... [id=app-4]
aws_kms_key_policy.encrypt_app: Refreshing state... [id=4b7905a0-b2d6-46dd-9db8-d1211429cda3]
aws_ecs_cluster.app_cluster: Refreshing state... [id=arn:aws:ecs:us-east-2:743794601996:cluster/app-4]
aws_security_group.endpoint-sg: Refreshing state... [id=sg-01ec0ad4e1a15615d]
aws_internet_gateway.this_igw: Refreshing state... [id=igw-0efc85be3815d6528]
aws_default_security_group.default: Refreshing state... [id=sg-0301b1a7a7f0fbb71]
aws_route_table.this_rt_private: Refreshing state... [id=rtb-046b2a4aeacedb247]
aws_lb_target_group.target_group: Refreshing state... [id=arn:aws:elasticloadbalancing:us-east-2:743794601996:targetgroup/app-4/244974b204720e0a]
aws_route_table.this_rt: Refreshing state... [id=rtb-09d7b5f268b4069b3]
aws_subnet.private[1]: Refreshing state... [id=subnet-0af31fa74eda838b6]
aws_vpc_endpoint.s3: Refreshing state... [id=vpce-0565ff144c5bb250b]
aws_subnet.private[0]: Refreshing state... [id=subnet-0974dcdbe41c4bbac]
aws_security_group.custom_sg: Refreshing state... [id=sg-07243a7140b9304f9]
aws_subnet.public[0]: Refreshing state... [id=subnet-0bb01ac720ac24033]
aws_subnet.public[1]: Refreshing state... [id=subnet-01f9a40b6742fd3f0]
aws_route.internet_route: Refreshing state... [id=r-rtb-09d7b5f268b4069b31080289494]
aws_security_group_rule.egress_load_balancer: Refreshing state... [id=sgrule-946088648]
aws_security_group_rule.ingress_load_balancer: Refreshing state... [id=sgrule-259871307]
aws_security_group_rule.ingress_vpc_endpoint: Refreshing state... [id=sgrule-3940337539]
aws_vpc_endpoint.cloudwatch: Refreshing state... [id=vpce-05659904fe5420f19]
aws_vpc_endpoint.ecr_api: Refreshing state... [id=vpce-05778e8c477113471]
aws_vpc_endpoint.ecr: Refreshing state... [id=vpce-05d51f06f2e3669c7]
aws_route_table_association.private[1]: Refreshing state... [id=rtbassoc-0c6f25a0ef5c29c74]
aws_route_table_association.private[0]: Refreshing state... [id=rtbassoc-033845353580e945c]
aws_lb.app_lb: Refreshing state... [id=arn:aws:elasticloadbalancing:us-east-2:743794601996:loadbalancer/app/app-4/4d2d587ec3b42d82]
aws_route_table_association.public[0]: Refreshing state... [id=rtbassoc-04ec8925791ee27cb]
aws_route_table_association.public[1]: Refreshing state... [id=rtbassoc-0397781f9956e732b]
aws_vpc_endpoint_route_table_association.s3_association: Refreshing state... [id=a-vpce-0565ff144c5bb250b1639019407]
aws_alb_listener.listener: Refreshing state... [id=arn:aws:elasticloadbalancing:us-east-2:743794601996:listener/app/app-4/4d2d587ec3b42d82/442e1e58b9e80242]

Changes to Outputs:
  + aws_lb_target_group        = "arn:aws:elasticloadbalancing:us-east-2:743794601996:targetgroup/app-4/244974b204720e0a"
  + cloud_watch_log_group_name = "/amazon-ecs/app-4/log"
  + cluster_name               = "app-4"
  + public_subnet_ids          = [
      + "subnet-0bb01ac720ac24033",
      + "subnet-01f9a40b6742fd3f0",
    ]
  + security_group_id          = "sg-07243a7140b9304f9"

You can apply this plan to save these new output values to the Terraform
state, without changing any real infrastructure.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: TFplan.JSON

To perform exactly these actions, run the following command to apply:
    terraform apply "TFplan.JSON"

Pushed by: @kunduso, Action: pull_request