Disable entity autowire (#4)

kunicmarko20 · Jan 17, 2019 · 72002d0 · 72002d0
1 parent df57ee9
commit 72002d0
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -139,6 +139,7 @@ use App\Entity\Category;
  *     controller=CategoryController::class,
  *     entity=Category::class,
  *     adminCode="admin_code",
+ *     autowireEntity=true,
  * )
  */
 class CategoryAdmin

diff --git a/src/Annotation/AdminOptions.php b/src/Annotation/AdminOptions.php
@@ -77,6 +77,11 @@ final class AdminOptions
      */
     public $controller;
 
+    /**
+     * @var bool
+     */
+    public $autowireEntity = true;
+
     public function getOptions(): array
     {
         return array_filter(

diff --git a/src/DependencyInjection/Compiler/AutoConfigureAdminClassesCompilerPass.php b/src/DependencyInjection/Compiler/AutoConfigureAdminClassesCompilerPass.php
@@ -102,7 +102,7 @@ private function setDefaultValuesForAnnotation(AdminOptions $annotation, string
             $annotation->adminCode = 'admin.' . Inflector::tableize($name);
         }
 
-        if (!$annotation->entity) {
+        if (!$annotation->entity && $annotation->autowireEntity) {
             [$annotation->entity, $managerType] = $this->findEntity($name);
 
             if (!$annotation->managerType) {

diff --git a/tests/DependencyInjection/Compiler/AutoConfigureAdminClassesCompilerPassTest.php b/tests/DependencyInjection/Compiler/AutoConfigureAdminClassesCompilerPassTest.php
@@ -4,6 +4,8 @@
 
 namespace KunicMarko\SonataAutoConfigureBundle\Tests\DependencyInjection\Compiler;
 
+use KunicMarko\SonataAutoConfigureBundle\Tests\Fixtures\Admin\DisableAutowireEntityAdmin;
+use KunicMarko\SonataAutoConfigureBundle\Tests\Fixtures\Entity\Category;
 use Doctrine\Common\Annotations\AnnotationReader;
 use KunicMarko\SonataAutoConfigureBundle\DependencyInjection\Compiler\AutoConfigureAdminClassesCompilerPass;
 use KunicMarko\SonataAutoConfigureBundle\DependencyInjection\SonataAutoConfigureExtension;
@@ -41,7 +43,7 @@ protected function setUp(): void
     /**
      * @dataProvider processData
      */
-    public function testProcess(string $admin, string $adminCode, array $tagOptions): void
+    public function testProcess(string $admin, ?string $entity, string $adminCode, array $tagOptions): void
     {
         $this->loadConfig([
             'entity' => [
@@ -74,13 +76,19 @@ public function testProcess(string $admin, string $adminCode, array $tagOptions)
             $tagOptions,
             $adminDefinition->getTag('sonata.admin')[0]
         );
+
+        $this->assertSame(
+            $entity,
+            $adminDefinition->getArgument(1)
+        );
     }
 
     public function processData(): array
     {
         return [
             [
                 CategoryAdmin::class,
+                Category::class,
                 'admin.category',
                 [
                     'manager_type' => 'orm',
@@ -92,6 +100,7 @@ public function processData(): array
             ],
             [
                 AnnotationAdmin::class,
+                Category::class,
                 'admin.annotation',
                 [
                     'manager_type' => 'orm',
@@ -101,6 +110,18 @@ public function processData(): array
                     'on_top' => false,
                 ],
             ],
+            [
+                DisableAutowireEntityAdmin::class,
+                null,
+                'admin.disable_autowire_entity',
+                [
+                    'manager_type' => 'orm',
+                    'label' => 'Disable Autowire Entity',
+                    'show_in_dashboard' => true,
+                    'keep_open' => false,
+                    'on_top' => false,
+                ],
+            ],
         ];
     }
 

diff --git a/tests/Fixtures/Admin/DisableAutowireEntityAdmin.php b/tests/Fixtures/Admin/DisableAutowireEntityAdmin.php
@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace KunicMarko\SonataAutoConfigureBundle\Tests\Fixtures\Admin;
+
+use KunicMarko\SonataAutoConfigureBundle\Annotation as Sonata;
+
+/**
+ * @Sonata\AdminOptions(autowireEntity=false)
+ *
+ * @author Marko Kunic <kunicmarko20@gmail.com>
+ */
+class DisableAutowireEntityAdmin
+{
+}