Skip to content
This repository has been archived by the owner on Nov 16, 2020. It is now read-only.

Add showMosaicButton annotation option #8

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Add showMosaicButton annotation option #8

merged 1 commit into from
Jan 22, 2019

Conversation

gremo
Copy link
Contributor

@gremo gremo commented Jan 22, 2019

Changelog

### Added
- missing `showMosaicButton` option in the AdminOptions annotation

Copy link
Owner

@kunicmarko20 kunicmarko20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the tests, please?

@gremo
Copy link
Contributor Author

gremo commented Jan 22, 2019

Sorry, forgot tests, fixed thanks.Sorry, forgot tests, fixed thanks.

@kunicmarko20 kunicmarko20 merged commit 26e06e7 into kunicmarko20:master Jan 22, 2019
@kunicmarko20
Copy link
Owner

Thank you @gremo

@gremo
Copy link
Contributor Author

gremo commented Jan 22, 2019

Thanks to you, maybe release 0.2.1? :)

@gremo gremo deleted the add-missing-mosaic-option branch January 22, 2019 11:41
@kunicmarko20
Copy link
Owner

I thought about doing that after you finish #7? if you are gonna do that

@kunicmarko20
Copy link
Owner

And it would probably be 0.3.0 😄

@gremo
Copy link
Contributor Author

gremo commented Jan 22, 2019

Well, I think there is nothing wrong pushing 0.2.1 for the new option, and then release 0.3.0... but it's up to you. By the way, my PR will not break BC, so it could be 0.2.2... do you agree?

@kunicmarko20
Copy link
Owner

there is no BC for 0.*. But this is more of addition and your new PR also, so that would be 0.3 and then 0.4 release, that is why I wanted to put both into 0.3.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants