Skip to content
This repository has been archived by the owner on Nov 16, 2020. It is now read-only.

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
kunicmarko20 committed Jul 21, 2018
1 parent 560025e commit be81b5d
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 8 deletions.
6 changes: 3 additions & 3 deletions tests/Fixtures/ChunkImportClass.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
*/
class ChunkImportClass extends TestCase implements Import, ChunkImport, BeforeImport
{
public function before(Iterator $items): Iterator
public function before(Iterator $items, array $additionalData): Iterator
{
$items->next();

Expand All @@ -26,12 +26,12 @@ public function chunkSize(): int
return 50;
}

public function map(array $item)
public function map(array $item, array $additionalData)
{
return $item;
}

public function save(array $items): void
public function save(array $items, array $additionalData): void
{
$this->assertLessThanOrEqual(50, count($items));
}
Expand Down
10 changes: 7 additions & 3 deletions tests/Fixtures/ImportClass.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,23 @@
*/
class ImportClass extends TestCase implements Import, BeforeImport
{
public function before(Iterator $items): Iterator
public function before(Iterator $items, array $additionalData): Iterator
{
$items->next();

return $items;
}

public function map(array $item)
public function map(array $item, array $additionalData)
{
if ($additionalData) {
$this->assertSame('testing', reset($additionalData));
}

return $item;
}

public function save(array $items): void
public function save(array $items, array $additionalData): void
{
$this->assertCount(999, $items);

Expand Down
3 changes: 1 addition & 2 deletions tests/Fixtures/ImportNestedJsonClass.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ class ImportNestedJsonClass extends ImportClass
{
/**
* @param ArrayIterator|Iterator $items
* @return Iterator
*/
public function before(Iterator $items): Iterator
public function before(Iterator $items, array $additionalData): Iterator
{
$iterator = new ArrayIterator($items->getArrayCopy()['data']);

Expand Down
10 changes: 10 additions & 0 deletions tests/ImporterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@ public function testExcelImportFromFile(): void
->import();
}

public function testWithAdditionalData(): void
{
$importer = $this->importerFactory->getImporter('xlsx');

$importer->fromFile(__DIR__ . '/Fixtures/fake.xlsx')
->useImportClass($this->importClass)
->withAdditionalData(['test' => 'testing'])
->import();
}

/**
* @expectedException \KunicMarko\Importer\Exception\NotSupportedException
*/
Expand Down

0 comments on commit be81b5d

Please sign in to comment.