Skip to content
This repository has been archived by the owner on Nov 16, 2020. It is now read-only.

Setting defaults using the configuration #7

Closed
gremo opened this issue Jan 22, 2019 · 5 comments
Closed

Setting defaults using the configuration #7

gremo opened this issue Jan 22, 2019 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gremo
Copy link
Contributor

gremo commented Jan 22, 2019

How about setting defaults using the configuration? Sometimes I need annotations just to change the labelTranslatorStrategy or the labelCatalogue.

sonata_auto_configure:
    defaults:
        label_catalogue: admin
        label_translator_strategy: sonata.admin.label.strategy.underscore
        show_mosaic_button: false
@kunicmarko20
Copy link
Owner

Sounds like a good idea. 👌

@kunicmarko20 kunicmarko20 added enhancement New feature or request help wanted Extra attention is needed labels Jan 22, 2019
@gremo
Copy link
Contributor Author

gremo commented Jan 22, 2019

Do you need a PR for this? Or you'll do it by yourself? I just discovered this bundle and I'm using Symfony 4, I'm really tired to define tons of admins by hand 😄

@kunicmarko20
Copy link
Owner

If you want to do it, go ahead. I can do it in the next few days. That was the point, make it easier for people. If it gets popular we will probably merge it back into the admin bundle.

@gremo
Copy link
Contributor Author

gremo commented Jan 22, 2019

That would be great! I'm working on this PR, in the meanwhile I added another one: #8 how about merging it?

@kunicmarko20
Copy link
Owner

Left a comment, CI is red.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants