Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason to not merge with vinniefalco/LuaBridge? #20

Closed
timfel opened this issue Feb 24, 2022 · 1 comment
Closed

Any reason to not merge with vinniefalco/LuaBridge? #20

timfel opened this issue Feb 24, 2022 · 1 comment

Comments

@timfel
Copy link

timfel commented Feb 24, 2022

I noticed there are some commits on the vinniefalco/LuaBridge repository that are not integrated here. Just curious: was there a particular reason not to integrate your changes into that repository?

@kunitoki
Copy link
Owner

I did initially wanted to contribute to it but i found that i could iterate faster by working on a separate fork and i needed those changes for my personal projects without also worrying on design decisions or be slowed down by breaking changes or code removals (i did remove some very unsafe and inefficient RefcountedPtr implementation).

@timfel timfel closed this as completed Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants