Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added favicons #3649

Closed
wants to merge 3 commits into from
Closed

Added favicons #3649

wants to merge 3 commits into from

Conversation

tanyagupta01
Copy link
Contributor

PR Description 📜

This PR adds favicons to the games : Blast Zone, Cut the rope, hand cricket, memory game, minesweeper, mini golf and whack a mole

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #3620

Added favicons to the games : Blast Zone, Cut the rope, hand cricket, memory game, minesweeper, mini golf and whack a mole
@kunjgit
Copy link
Owner

kunjgit commented May 22, 2024

Thank you @tanyagupta01 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working!
either provide link to the images by storing images in the games image folder and also use the proper syntax while providing the link.
We need high contrast images thus change the images of mini_golf and hand_cricket if not found remove them.
Hope you will make changes soon!!

added the favicons of blast zone, cut the rope, memory game, minesweeper and whack a mole correctly. Also, changed the favicons of mini golf and hand cricket.
@kunjgit
Copy link
Owner

kunjgit commented Jun 10, 2024

Thank you @tanyagupta01 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding favicons [Enhancement]:
3 participants