Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Samurai Fighting Game #4640

Merged
merged 6 commits into from
Jul 6, 2024
Merged

Added Samurai Fighting Game #4640

merged 6 commits into from
Jul 6, 2024

Conversation

tanyagupta01
Copy link
Contributor

PR Description 📜

Samurai Fighting Game

Samurai fighting games have carved out a unique niche in the gaming world, blending intense combat with rich cultural and historical themes. These games often feature stunning visuals, detailed characters, and engaging storylines that immerse players in the world of the samurai.

How to Play

  • PLAYER 1 can use the following keys:
    A D and W to move
    spacebar to hit

  • PLAYER 2 can use the following keys:
    leftarrow rightarrow and uparrow to move
    downarrow to hit

Fixes #4631

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Samurai Fighting Game Screenshot 2024-06-20 at 10 11 25 PM

@kunjgit
Copy link
Owner

kunjgit commented Jun 20, 2024

Thank you @tanyagupta01 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

ishita-43
ishita-43 requested changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes

README.md Outdated
@@ -794,6 +794,7 @@ This repository also provides one such platforms where contributers come over an
|[Pottery-Game](https://github.com/kunjgit/GameZone/tree/main/Games/Pottery-Game)|
| [Ganesh_QR_Maker](https://github.com/kunjgit/GameZone/tree/main/Games/Ganesh_QR_Maker) |
|[Wheel_of_Fortunes](https://github.com/Saipradyumnagoud/GameZone/tree/main/Games/Wheel_of_Fortunes)|
|[Samurai_Fighting_Game](https://github.com/Saipradyumnagoud/GameZone/tree/main/Games/Samurai_Fighting_Game)|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the format of the link as other games replace your name with the name of this repository

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishita-43 Done.

README.md Outdated
@@ -794,6 +794,7 @@ This repository also provides one such platforms where contributers come over an
|[Pottery-Game](https://github.com/kunjgit/GameZone/tree/main/Games/Pottery-Game)|
| [Ganesh_QR_Maker](https://github.com/kunjgit/GameZone/tree/main/Games/Ganesh_QR_Maker) |
|[Wheel_of_Fortunes](https://github.com/Saipradyumnagoud/GameZone/tree/main/Games/Wheel_of_Fortunes)|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the name of this also if its your game

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it is not my game but I could change it if you want.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok also resolve merge conflicts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

ishita-43
ishita-43 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Jul 5, 2024
@kunjgit kunjgit merged commit 7b9d7f2 into kunjgit:main Jul 6, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 6, 2024

Thank you @tanyagupta01 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New game]: Samurai Fighting Game
3 participants
@tanyagupta01 @kunjgit @ishita-43