-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add simple tests #42
add simple tests #42
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 40.38% 45.89% +5.50%
==========================================
Files 20 24 +4
Lines 1186 1266 +80
==========================================
+ Hits 479 581 +102
+ Misses 646 614 -32
- Partials 61 71 +10 see 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config
와 PatterendString
타입에 대한 테스트코드 감사합니다.
근데 import 패키지 정렬 순만 틀려도 go fmt
가 fail이 나네요. IDE에서 go fmt를 수행하고 커밋하는 룰을 정해야 할 것 같습니다. 저는 Goland에서 setting > Before Commit > go fmt 적용하도록 해놓겠습니다.
네 암튼 확인이 되니까 사후에 make checks를 한번 돌려주면 되고요. PR 등록시 reviewer를 비워놨다가 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모든 workflow 통과 확인했습니다 감사합니다
리뷰 감사합니다. merge합니다. |
What this PR does / why we need it (변경 내용 / 필요성):
간단한 테스트를 추가하여 커버리지를 높혔습니다.
make test-cover
를 추가하여 커버리지를 미리 확인할 수 있게 하였습니다.Which issue(s) this PR fixes (관련 이슈):
none
Special notes for your reviewer (리뷰어에게 하고 싶은 말):
리뷰 감사합니다.
Additional documentation, usage docs, etc. (기타 관련 문서, 사용법 등):
사용 예시
전체 커버리지가 일정한 값(50.0%) 이상이면 ✔️ PASS 그렇지 않으면 ❌ FAIL로 보여줍니다.