Refactoring minor #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmnote
approved these changes
Mar 16, 2023
| @@ -15,21 +15,21 @@ func getDiskAvailableBytes(path string) (string, error) { | |||
| // get absolute path | |||
| absPath, err := filepath.Abs(path) | |||
| if err != nil { | |||
| return "", fmt.Errorf("cannot get absoluth path for [%s]: %s", path, err) | |||
| return "", fmt.Errorf("cannot get absoluth path for [%s]: %w", path, err) | |||
There was a problem hiding this comment.
absPath, err := filepath.Abs(path) 에서 발생한 err의 정보를 getDiskAvailableBytes 함수를 호출한 곳에서 알 수 없습니다. 물론 string으로 어떤 에러인지 확인할 수 있지만 Unwrap으로 해당 에러 타입을 검사할 수 없습니다.
따라서 만약 getDiskAvailableBytes 함수 호출 부분에서 filepath.Abs 함수의 에러를 핸들링 할 수 없습니다.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it (변경 내용 / 필요성):
Minor Refactoring
util.Exec제거time.Time중복 conversion%w사용Which issue(s) this PR fixes (관련 이슈):
None
Special notes for your reviewer (리뷰어에게 하고 싶은 말):
#43 리팩토링 이전에 IDE에서 알려주는 간단한 리팩토링 진행했습니다.
Additional documentation, usage docs, etc. (기타 관련 문서, 사용법 등):