cluster operator: init helm chart #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preliminary-kurator canceled.
|
zirain
force-pushed
the
operator-helm
branch
from
db583a1
to
71e3dff
Compare
hzxuzhonghu
reviewed
Nov 15, 2022
| @@ -0,0 +1,39 @@ | |||
| # Cluster Operator | |||
There was a problem hiding this comment.
This is not the right place to put readme
There was a problem hiding this comment.
will move to doc when stable
hzxuzhonghu
reviewed
Nov 15, 2022
| } | ||
|
|
||
| c := newClient() | ||
| resources, err := c.Build(resp.Body, false) |
There was a problem hiding this comment.
does not resp.Body need close?
hzxuzhonghu
reviewed
Nov 15, 2022
| OUTPUT_DIR=${HELM_CRD_BASE} CLUSTER_API_PROVIDER_VERSION=${CLUSTER_API_PROVIDER_VERSION} AWS_PROVIDER_VERSION=${AWS_PROVIDER_VERSION} go run cmd/crd-gen-tool/main.go | ||
|
|
||
| # sed cert | ||
| sed -i "s|caBundle: Cg==|caBundle: ${CA_BUNDLE}|g" $(find ${HELM_CRD_BASE} -type f) |
hzxuzhonghu
approved these changes
Nov 15, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hzxuzhonghu
reviewed
Nov 15, 2022
| - v1beta1 | ||
| clientConfig: | ||
| service: | ||
| name: capa-webhook-service |
hzxuzhonghu
reviewed
Nov 15, 2022
| name: kurator-validating-webhook-configuration | ||
| webhooks: | ||
| - admissionReviewVersions: | ||
| - v1beta1 |
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
zirain
force-pushed
the
operator-helm
branch
from
71e3dff
to
48dd1b5
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hejianpeng hejianpeng2@huawei.com
What type of PR is this?
What this PR does / why we need it:
/kind feature
Which issue(s) this PR fixes:
part of #96
Special notes for your reviewer:
Does this PR introduce a user-facing change?: