init cluster webhook #172
Merged
init cluster webhook #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preliminary-kurator canceled.
|
hzxuzhonghu
reviewed
Feb 28, 2023
hzxuzhonghu
reviewed
Feb 28, 2023
hzxuzhonghu
reviewed
Feb 28, 2023
hzxuzhonghu
reviewed
Feb 28, 2023
hzxuzhonghu
reviewed
Feb 28, 2023
hzxuzhonghu
reviewed
Feb 28, 2023
hzxuzhonghu
reviewed
Feb 28, 2023
| return allErrs | ||
| } | ||
|
|
||
| func validateCIDR(cidr string, fldPath *field.Path) field.ErrorList { |
There was a problem hiding this comment.
duplicate with validateCIDRBlocks？
There was a problem hiding this comment.
difference between []string and string
hzxuzhonghu
reviewed
Feb 28, 2023
| var allErrs field.ErrorList | ||
|
|
||
| // The Cluste name is used as a label value, so it must be a valid label value. | ||
| if errs := validation.IsValidLabelValue(in.Name); len(errs) > 0 { |
There was a problem hiding this comment.
I think this is not user friendly
There was a problem hiding this comment.
Cluster API require this, we can do some conversion?
zirain
force-pushed
the
webhook
branch
2 times, most recently
from
3868aef
to
1413eb0
Compare
hzxuzhonghu
reviewed
Feb 28, 2023
hzxuzhonghu
reviewed
Feb 28, 2023
zirain
force-pushed
the
webhook
branch
7 times, most recently
from
f19ce8d
to
0223cdc
Compare
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
add webhook for Kurator Cluster API
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: